feat(anvil): add block context overrides for eth_call and eth_estimateGas #10487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
May 10, 2025
|
Thanks @mattsse for your feedback! I will squash it before marking this PR as ready. |
mablr
force-pushed
the
feature/anvil-block-overrides
branch
from
fb16804 to
5590414
Compare
…eGas This commit implements block context overrides for eth_call and eth_estimateGas RPC methods, allowing users to specify block parameters like timestamp, number, difficulty, etc. for call execution context. Key changes: - BlockOverrides added to EthRequest enum variants for eth_call and eth_estimateGas - Block overrides handling implemented in `anvil::eth::backend::mem::state` as `apply_block_overrides()` function (ported from reth) - Add new error type EvmOverrideError to group state and block override related errors (due to fork mode) - State override handling refactored: - Rename `apply_cached_db_state_override()` to `apply_state_overrides()` - Modify to take mutable `CacheDB` reference instead of creating new instance - Consistent pattern for `apply_state_overrides()` and `apply_block_overrides()`
mablr
force-pushed
the
feature/anvil-block-overrides
branch
from
5590414 to
180f897
Compare
mablr
requested review from
DaniPopes,
klkvr,
grandizzy,
yash-atreya and
zerosnacks
as code owners
yash-atreya
reviewed
May 21, 2025
| @@ -1143,7 +1144,7 @@ async fn test_estimate_gas() { | |||
|
|
|||
| // Estimate gas with state override implying sufficient funds. | |||
| let gas_estimate = api | |||
| .estimate_gas(WithOtherFields::new(tx), None, Some(state_override)) | |||
| .estimate_gas(WithOtherFields::new(tx), None, EvmOverrides::new(Some(state_override), None)) | |||
There was a problem hiding this comment.
Can we add a test case for BlockOverrides as well, otherwise lgtm!
There was a problem hiding this comment.
quickly added a block number override test case
mattsse
approved these changes
May 21, 2025
| @@ -1143,7 +1144,7 @@ async fn test_estimate_gas() { | |||
|
|
|||
| // Estimate gas with state override implying sufficient funds. | |||
| let gas_estimate = api | |||
| .estimate_gas(WithOtherFields::new(tx), None, Some(state_override)) | |||
| .estimate_gas(WithOtherFields::new(tx), None, EvmOverrides::new(Some(state_override), None)) | |||
There was a problem hiding this comment.
quickly added a block number override test case
zerosnacks
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #10458 by implementing block context overrides for
eth_callandeth_estimateGasRPC methods, allowing users to specify block parameters like timestamp, number, difficulty, etc. for call execution context.Solution
Key changes:
anvil::eth::backend::mem::stateasapply_block_overrides()function (ported from reth)apply_cached_db_state_override()toapply_state_overrides()CacheDBreference instead of creating new instanceapply_state_overrides()andapply_block_overrides()PR Checklist
Add Tests with State and Block overrides foreth_callandeth_estimateGas